[
https://issues.apache.org/jira/browse/OAK-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264015#comment-15264015
]
Julian Reschke edited comment on OAK-4112 at 12/20/17 9:36 AM:
---------------------------------------------------------------
I notice that the RDB variant had some DEBUG level logic so we can inspect the
Bloom filter's performance when done.
{noformat}
if (LOG.isDebugEnabled()) {
if (filter != null) {
LOG.debug("Disposing QueryContext for range " + fromKey +
"..." + toKey + " - filter fpp was: "
+ filter.expectedFpp());
} else {
LOG.debug("Disposing QueryContext for range " + fromKey +
"..." + toKey + " - no filter was needed");
}
}
{noformat}
Should we re-add that?
was (Author: reschke):
I notice that the RDB variant had some DEBUG level logic so we can onpsect the
Bloom filter's performance when done.
{noformat}
if (LOG.isDebugEnabled()) {
if (filter != null) {
LOG.debug("Disposing QueryContext for range " + fromKey +
"..." + toKey + " - filter fpp was: "
+ filter.expectedFpp());
} else {
LOG.debug("Disposing QueryContext for range " + fromKey +
"..." + toKey + " - no filter was needed");
}
}
{noformat}
Should we re-add that?
> Replace the query exclusive lock with a cache tracker
> -----------------------------------------------------
>
> Key: OAK-4112
> URL: https://issues.apache.org/jira/browse/OAK-4112
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk, mongomk
> Reporter: Tomek Rękawek
> Assignee: Tomek Rękawek
> Labels: performance
> Fix For: 1.4.6, 1.5.2, 1.6.0
>
> Attachments: OAK-4112-1.patch, OAK-4112-2.patch, OAK-4112-3.patch,
> OAK-4112-4.patch, OAK-4112-putifnewer.patch, OAK-4112.patch
>
>
> The {{MongoDocumentStore#query()}} method uses an expensive
> {{TreeLock#acquireExclusive}} method, introduced in OAK-1897 to avoid caching
> outdated documents.
> It should be possible to avoid acquiring the exclusive lock, by tracking the
> cache changes that occurs during the Mongo find() operation. When the find()
> is done, we can update the cache with the received documents if they haven't
> been invalidated in the meantime.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
