[ 
https://issues.apache.org/jira/browse/OAK-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318578#comment-16318578
 ] 

Alex Deparvu commented on OAK-7024:
-----------------------------------

The impact is mainly related to the _java.security.acl.Group_ class, which Oak 
uses heavily.

Overview of impact (ignoring tests)
* oak-security-spi
(all of the classes here are exposed as apis, this will be a major pain to 
update)
** PrincipalProvider#getGroupMembership returns Set<Group>
** CompositePrincipalProvider inherits #getGroupMembership from 
PrincipalProvider
** EmptyPrincipalProvider inherits #getGroupMembership from PrincipalProvider
** EveryonePrincipal implements Group
* oak-core
** CompiledPermissionImpl checks instanceof Group
** PrincipalProviderImpl inherits #getGroupMembership from PrincipalProvider, 
instanceof checks
** AbstractGroupPrincipal implements Group
** ImpersonationImpl instanceof checks
** UserPrincipalProvider inherits #getGroupMembership from PrincipalProvider, 
heavy use of groups
 * oak-auth-external
** ExternalGroupPrincipalProvider inherits #getGroupMembership from 
PrincipalProvider, instanceof checks
** ExternalGroupPrincipal implements Group
** ExternalPrincipalConfiguration unused Group import

It seems we need to agree on what to do next. I couldn't find a replacement for 
the Group class, but maybe I'm missing something?
A very simple solution is to copy the class over to Oak and continue using it 
(still doesn't save us from having to update all of this code though).


> java.security.acl deprecated in Java 10, marked for removal in Java 11
> ----------------------------------------------------------------------
>
>                 Key: OAK-7024
>                 URL: https://issues.apache.org/jira/browse/OAK-7024
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: security
>            Reporter: Julian Reschke
>            Assignee: Alex Deparvu
>             Fix For: 1.10
>
>
> See <https://bugs.openjdk.java.net/browse/JDK-8175094> and 
> <https://bugs.openjdk.java.net/browse/JDK-8191138>.
> Need to understand how this affects public Oak APIs, and what to do with them 
> on Java 11 (which will be an LTS release we probably need to support with Oak 
> 1.10).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to