[ 
https://issues.apache.org/jira/browse/OAK-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325612#comment-16325612
 ] 

Vikas Saurabh edited comment on OAK-7151 at 1/14/18 2:57 PM:
-------------------------------------------------------------

[~tmueller], attaching [^OAK-7151.patch]. Do see {{ExcerptTest}} if that 
represents the expectation correctly.

Btw, still to do - xpath to support syntax like
{noformat}
//*[jcr:contains(., 'foo')/rep:excerpt(@foo)
//*[jcr:contains(., 'foo')/rep:excerpt(rel/@foo)
{noformat}


was (Author: catholicon):
[~tmueller], attaching [^OAK-7151.patch]. Do see {{ExcerptTest}} if that 
represents the expectation correctly.

Btw, still to do - xpath (maybe it works already - haven't checked yet).

> Support indexed based excerpts on properties
> --------------------------------------------
>
>                 Key: OAK-7151
>                 URL: https://issues.apache.org/jira/browse/OAK-7151
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: lucene
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>             Fix For: 1.10
>
>         Attachments: OAK-7151.patch
>
>
> As discovered in OAK-4401 we fallback to {{SimpleExcerptProvider}} when 
> requesting excerpts for properties.
> The issue as highlighted in [~teofili]'s comment \[0] is that we at time of 
> query we don't have information about which all columns/fields would be 
> required for excerpts.
> A possible approach is that the query specified explicitly which columns 
> would be required in facets (of course, node level excerpt would still be 
> supported). This issue is to track that improvement.
> Note: this is *not* a substitute for OAK-4401 which is about doing saner 
> highlighting when {{SimpleExcerptProvider}} comes into play e.g. despite this 
> issue excerpt for non-stored fields (properties which aren't configured with 
> {{useInExcerpt}} in the index definition}, we'd need to fallback to 
> {{SimpleExcerptProvider}}.
> /[~tmueller]
> \[0]: 
> https://issues.apache.org/jira/browse/OAK-4401?focusedCommentId=15299857&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15299857



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to