[ 
https://issues.apache.org/jira/browse/OAK-6373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16343183#comment-16343183
 ] 

Andrei Dulceanu commented on OAK-6373:
--------------------------------------

I adapted the old tests to take into account the new {{--head-}} and 
{{-checkpoints}} options and also added new tests for dealing with invalid 
revisions. [~mduerig], [~frm], could you take a look at the latest commits in 
my branch [0]?
{quote}Maybe the ConsistencyChecker.checkConsistency() should be broken down as 
it is getting quite long?
{quote}
I started refactoring that method, but didn't come up with a good outcome 
without cluttering the new methods with lots of parameters. I would leave this 
as it is for the time being. We can take this up again in a new issue focused 
on simplifying/cleaning the code. WDYT?

[0] [https://github.com/dulceanu/jackrabbit-oak/commits/issues/OAK-6373]

> oak-run check should also check checkpoints 
> --------------------------------------------
>
>                 Key: OAK-6373
>                 URL: https://issues.apache.org/jira/browse/OAK-6373
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: run, segment-tar
>            Reporter: Michael Dürig
>            Assignee: Andrei Dulceanu
>            Priority: Major
>              Labels: candidate_oak_1_8, tooling
>             Fix For: 1.9.0, 1.10
>
>
> {{oak-run check}} does currently *not* traverse and check the items in the 
> checkpoint. I think we should change this and add an option to traverse all, 
> some or none of the checkpoints. When doing this we need to keep in mind the 
> interaction of this new feature with the {{filter}} option: the paths passed 
> through this option need then be prefixed with {{/root}}. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to