[
https://issues.apache.org/jira/browse/OAK-7225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374099#comment-16374099
]
Davide Giannella commented on OAK-7225:
---------------------------------------
It's not public API but is used during repository construction, when you
register you want to have an atomic counter functionality. So it's kind-of
middle-ground between public and private.
IMO replacing with standard java will help us in the future in case anything
change on the guava side, and the change if you can see it's very trivial with
very low risk.
Tell me if you have anything against the patch, otherwise I will commit it next
week.
Getting rid of guava completely was definitely out of scope but as I was
investigating, I thought, let me see what it would take. Eventually the less we
depends on external library the less the impact a change in those will have on
us.
> Replace AtomicCounter Supplier
> ------------------------------
>
> Key: OAK-7225
> URL: https://issues.apache.org/jira/browse/OAK-7225
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Affects Versions: 1.4.0, 1.6.0
> Reporter: Davide Giannella
> Assignee: Davide Giannella
> Priority: Major
> Attachments: OAK-7225-0.diff
>
>
> In the
> [AtomicCounter|https://github.com/apache/jackrabbit-oak/blob/7a7aa1e5d4f53f5bfb410f58264c237b288f5c74/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/atomic/AtomicCounterEditorProvider.java#L121]
> we use guava's Supplier which should be trivially replaced by the JDK8
> [java.util.function.Supplier|https://docs.oracle.com/javase/8/docs/api/java/util/function/Supplier.html].
> In case of backports to Oak 1.4, and therefore Java7 it should be possible to
> workaround the FunctionalInterface with a utility class.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
