[ 
https://issues.apache.org/jira/browse/OAK-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378758#comment-16378758
 ] 

Francesco Mari commented on OAK-7280:
-------------------------------------

{{segmentOverflow}} has been moved to {{DefaultSegmentWriterTest}}, it's not 
gone missing. 

The rationale behind moving only some of the tests in {{RecordTest}} is that 
the moved tests assert a behaviour implemented exclusively by 
{{DefaultSegmentWriter}}. The remaining tests in {{RecordTest}} test the 
behaviour documented by the {{SegmentWriter}} API. It felt right to separate 
the two things, but I can put them all back together.

> Remove superfluous methods from SegmentWriter
> ---------------------------------------------
>
>                 Key: OAK-7280
>                 URL: https://issues.apache.org/jira/browse/OAK-7280
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>             Fix For: 1.10
>
>
> Some methods in {{SegmentWriter}} are only used in test code. Production code 
> works only on a much smaller subset of the methods exposed by 
> {{SegmentWriter}}. As such, the superfluous methods should be removed and the 
> tests adapted.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to