[
https://issues.apache.org/jira/browse/OAK-7470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463536#comment-16463536
]
Robert Munteanu commented on OAK-7470:
--------------------------------------
[~anchela] - from a backwards compatibility point of view the changes look
correct and should have no impact on consumers.
FWIW ( and probably nitpicking ) : I am not a heavy user of the Tree API, but I
wonder if the {{TreeProvider}} is the best place to add this method. This
interface handles {{NodeState}} -> {{Tree}} conversions so far, now we're
adding {{Tree}} -> {{NodeState}} which makes it more than {{TreeProvider}} .
Renaming the class would be breaking BC, so it's a no-go. The new method could
be moved to a new interface or added to the {{Tree}} interface itself ( not
sure if feasible ) but it might complicate how we consume that API.
> Remove Usage of ImmutableTree and AbstractTree in Security Code
> ---------------------------------------------------------------
>
> Key: OAK-7470
> URL: https://issues.apache.org/jira/browse/OAK-7470
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: authorization-cug, core, security-spi
> Reporter: angela
> Assignee: angela
> Priority: Major
> Labels: m12n
> Attachments: OAK-7470-tests.patch, OAK-7470.patch
>
>
> With a minor extension to {{TreeProvider}} we would be able to get rid of the
> direct casting to implementation details like {{ImmutableTree}} and
> {{AbstractTree}} altogether.
> [~stillalex], patch for review will follow right away.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
