[ 
https://issues.apache.org/jira/browse/OAK-7499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486800#comment-16486800
 ] 

angela edited comment on OAK-7499 at 5/23/18 6:49 AM:
------------------------------------------------------

[~stillalex], 
- regarding _oak-core-spi_: that would have my preference as well. but 
unfortunately that's not possible as it would lead to cyclic dependencies to 
_oak-store-spi_. i tried to refactor that out but ultimately gave up... if you 
see I solution that I overlooked, I am all for it.
- regarding {{RepositoryException}}: no strong preference... probably a 
leftover from extracting the interface.
- regarding multiple issues: i wanted to get a sense on whether it's possible 
to can refactor all the plugins-usages and get a coherent way of doing it. i 
decided to treat the indexing separate and was already struggling with local 
merge conflicts once i wanted to put all pieces together... but I can try to 
split it if you want me to.


was (Author: anchela):
[~stillalex], 
- regarding _oak-core-spi_: that would have my preference as well. but 
unfortunately that's not possible due as it would lead to cyclic dependencies 
to _oak-store-spi_. i tried to refactor that out but ultimately gave up... if 
you see I solution that I overlooked, I am all for it.
- regarding {{RepositoryException}}: no strong preference... probably a 
leftover from extracting the interface.
- regarding multiple issues: i wanted to get a sense on whether it's possible 
to can refactor all the plugins-usages and get a coherent way of doing it. i 
decided to treat the indexing separate and was already struggling with local 
merge conflicts once i wanted to put all pieces together... but I can try to 
split it if you want me to.

> Dependencies on various 'plugins'
> ---------------------------------
>
>                 Key: OAK-7499
>                 URL: https://issues.apache.org/jira/browse/OAK-7499
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: angela
>            Priority: Major
>         Attachments: OAK-7499-adjustsecuritycode.patch, 
> OAK-7499-extractplugins.patch
>
>
> subtask of OAK-7498 to drop usage of plugin classes directly from security 
> code base:
> - extract interfaces for managers and provider services
> - replace usage of implementenations



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to