[
https://issues.apache.org/jira/browse/OAK-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495138#comment-16495138
]
angela edited comment on OAK-7510 at 5/30/18 1:16 PM:
------------------------------------------------------
[~stillalex], i finally had time to take a closer look at the patch above.
looks very good to me in general. there is 1 thing though, that i didn't
understand and find counterintuitive: why does
{{OpenAuthorizationConfiguration.java}} needs to know about the inner workings
of the privilege implementation and create the require content structure below
_/jcr:system/rep:privileges_? that doesn't look right to me and i wonder, why
this was needed.
was (Author: anchela):
[~stillalex], i finally had time to take a closer look at the patch above.
looks very good to me in general. there is 1 thing though, that i didn't
understand and find a counterintuitive: why does
{{OpenAuthorizationConfiguration.java}} needs to know about the inner workings
of the privilege implementation and create the require content structure below
_/jcr:system/rep:privileges_? that doesn't look right to me and i wonder, why
this was needed.
> Run repository initializers with hooks
> --------------------------------------
>
> Key: OAK-7510
> URL: https://issues.apache.org/jira/browse/OAK-7510
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core
> Reporter: Alex Deparvu
> Assignee: Alex Deparvu
> Priority: Major
> Labels: modularization
>
> Currently the repository initializers (RepositoryInitializer and
> WorkspaceInitializer) run when the repo boots without any hooks [0] which
> means that current RepositoryInitializers need to setup custom Roots (roots
> with hardcoded editor providers like NamespaceEditorProvider and
> TypeEditorProvider) on top of the provided builders to be able to setup
> properly. I'm looking at the InitialContent [1] and the CugConfiguration [2]
> in the context of installing node types.
> I would like to look into removing the hardcoded providers and trying to run
> all existing editors over the content produced by the initializers.
> As an added benefit this will allow decoupling of hard dependencies between
> components (see for example OAK-7499)
> [0]
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/Oak.java#L687
>
> [1]
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/InitialContent.java#L134
> [2]
> https://github.com/apache/jackrabbit-oak/blob/trunk/oak-authorization-cug/src/main/java/org/apache/jackrabbit/oak/spi/security/authorization/cug/impl/CugConfiguration.java#L162
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
