[
https://issues.apache.org/jira/browse/OAK-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497960#comment-16497960
]
Julian Reschke edited comment on OAK-6346 at 6/1/18 1:06 PM:
-------------------------------------------------------------
Checking what we have today:
{noformat}
jackrabbit/2.16/jackrabbit-parent/pom.xml:
<comparisonVersion>2.16.0</comparisonVersion>
jackrabbit/trunk/jackrabbit-parent/pom.xml:
<comparisonVersion>2.16.1</comparisonVersion>
oak/1.8/oak-parent/pom.xml:
<comparisonVersion>1.6.2</comparisonVersion>
oak/trunk/oak-parent/pom.xml:
<comparisonVersion>1.8.0</comparisonVersion>
{noformat}
This looks very wrong.
IMHO:
- in stable branches, we usually should let default the comparisonVersion
(which would make it the previous release)
- in trunk, we should specify the last stable release (today: Jackrabbit 2.16.1
and Oak 1.8.3)
- http://jackrabbit.apache.org/jcr/creating-releases.html needs to point out
that if a stable release from the newest stable branch is made, the
comparisonVersion in trunk needs to be updated
[~mreutegg], [~chetanm]?
Independant of that, we need to ensure that if the baseline check asks for a
version change on an older branch (Jackrabbit <= 2.14, Oak <= 1.6), a lot of
care needs to be applied.
For now, I'll implement these changes for Jackrabbit, but will wait for
feedback before touching Oak.
was (Author: reschke):
Checking what we have today:
{noformat}
jackrabbit/2.16/jackrabbit-parent/pom.xml:
<comparisonVersion>2.16.0</comparisonVersion>
jackrabbit/trunk/jackrabbit-parent/pom.xml:
<comparisonVersion>2.16.1</comparisonVersion>
oak/1.8/oak-parent/pom.xml:
<comparisonVersion>1.6.2</comparisonVersion>
oak/trunk/oak-parent/pom.xml:
<comparisonVersion>1.8.0</comparisonVersion>
{noformat}
This looks very wrong.
IMHO:
- in stable branches, we usually should let default the comparisonVersion
(which would make it the previous release)
- in trunk, we should specify the last stable release (today: Jackrabbit 2.16.1
and Oak 1.8.3)
- http://jackrabbit.apache.org/jcr/creating-releases.html needs to point out
that if a stable release from the newest stable branch is made, the
comparisonVersion in trunk needs to be updated
[~mreutegg], [~chetanm]
Independant of that, we need to ensure that if the baseline check asks for a
version change on an older branch (Jackrabbit <= 2.14, Oak <= 1.6), a lot of
care needs to be applied.
For now, I'll implement these changes for Jackrabbit, but will wait for
feedback before touching Oak.
> Set baseline plugin comparison version to 1.6.0
> -----------------------------------------------
>
> Key: OAK-6346
> URL: https://issues.apache.org/jira/browse/OAK-6346
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: parent
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Priority: Major
> Fix For: 1.10
>
> Attachments: OAK-6346-v1.patch, release-process-v1.patch
>
>
> The purpose of baseline plugin is to ensure that any change in api get
> reflected in exported version of the package. Currently the baseline plugin
> compares against the immediate previous version.
> This causes issue with unstable branches where new features are being
> implemented and which evolve over few minor release on the trunk. In such
> cases its possible that a new method expose in 1.7.1 gets removed later in
> 1.7.2 (as happened in OAK-6337).
> It would be better to configure baseline plugin to check against releases
> from stable branch so that we can ensure that package versions are properly
> aligned against stable versions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
