[
https://issues.apache.org/jira/browse/OAK-7512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507922#comment-16507922
]
Julian Reschke edited comment on OAK-7512 at 6/11/18 11:21 AM:
---------------------------------------------------------------
> 1) Checked Jackrabbit source, and it appears to do the same, using
> DateVersionSelector.
It does, however the version manager ensures that no two versions created by
the same VM will have the same timestamp. See
{{InternalVersionHistoryImpl.getCurrentTime()}}
(<https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java#L681>).
Should we adopt this approach?
(note that on a sufficiently fast system, this could lead to creation
timestamps to be in the future)
was (Author: reschke):
> 1) Checked Jackrabbit source, and it appears to do the same, using
> DateVersionSelector.
It does, however the version manager ensures that no two versions created by
the same VM will have the same timestamp. See
{{InternalVersionHistoryImpl.getCurrentTime()}}
(<https://github.com/apache/jackrabbit/blob/trunk/jackrabbit-core/src/main/java/org/apache/jackrabbit/core/version/InternalVersionHistoryImpl.java#L681>).
Should we adopt this approach?
> RestoreTest.testRestoreNameJcr2 occasionally failing
> ----------------------------------------------------
>
> Key: OAK-7512
> URL: https://issues.apache.org/jira/browse/OAK-7512
> Project: Jackrabbit Oak
> Issue Type: Task
> Components: jcr
> Affects Versions: 1.6.11, 1.9.2
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Minor
> Attachments: OAK-7512.diff
>
>
> This tests occasionally fails for me:
> {noformat}
> testRestoreNameJcr2(org.apache.jackrabbit.test.api.version.RestoreTest):
> restore must restore child node version 1.0. expected:<1.[0]> but was:<1.[1]>
> {noformat}
> I *suspect* it is timing related (because it seems to happen more frequently
> when the system is busy).
> Last seen on 1.6 branch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
