[ 
https://issues.apache.org/jira/browse/OAK-7555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16517015#comment-16517015
 ] 

Marcel Reutegger commented on OAK-7555:
---------------------------------------

The three counters add redundant information. In my view it would be better to 
just track the number of GC runs and those that failed. The successful runs can 
be calculated with the other two.

I'm also not happy with renaming existing metrics. They are part of the 1.8 
release and there may be existing applications that depend on it. How about 
adding the prefix only for the new metrics you'd like to introduce?

> Enable collection of simple operation stats for Revision garbage collection
> ---------------------------------------------------------------------------
>
>                 Key: OAK-7555
>                 URL: https://issues.apache.org/jira/browse/OAK-7555
>             Project: Jackrabbit Oak
>          Issue Type: New Feature
>          Components: documentmk
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>            Priority: Major
>             Fix For: 1.10, 1.9.5
>
>         Attachments: OAK-7555.patch
>
>
> Add simple stats related to the revision gc:
> * Start counter
> * Finish success counter
> * Finish failure counter



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to