[
https://issues.apache.org/jira/browse/OAK-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571551#comment-16571551
]
Michael Dürig commented on OAK-7688:
------------------------------------
[~mreutegg] +1 for the patch. I like this approach as it clearly singles out
the places where a "full" value factory is needed. This should greatly simplify
implementing the binary access feature from OAK-7569 on top.
* I would prefer to remove the static methods right away. If not we should
also annotate them with @Deprecated. In any case, let's track this with a
separate issue.
* I would prefer the name {{PartialValueFactory}} over {{ValueFactoryStub}}
* As we are touching this area I would also like to properly sort out the
nullability annotations. My IDE is giving me warnings in various places. I'd
happily address this as an afterthought once the patch is committed.
> Replace usage of static ValueFactoryImpl methods
> ------------------------------------------------
>
> Key: OAK-7688
> URL: https://issues.apache.org/jira/browse/OAK-7688
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: store-spi
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Labels: technical_debt
> Fix For: 1.10
>
>
> The ValueFactoryImpl has a few static methods that are used to create a
> {{Value}} from a {{PropertyState}} or {{PropertyValue}}. Those methods should
> be refactored to make it easier to add a {{BlobAccessProvider}} for OAK-7569.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
