[ 
https://issues.apache.org/jira/browse/OAK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593454#comment-16593454
 ] 

Tomek Rękawek commented on OAK-7710:
------------------------------------

The CommitInfo-base approach seems promising.

In the meantime, I think we may make the CompositeNodeStore implementation 
easier by using the fact, that the partial stores are always read-only. Current 
CompositeNodeStore somehow assumes this already, but on the other hand it has 
multiple {{if}} checks to test if it's actually the case and actually have some 
logic to be performed if it isn't. We can remove the {{if}}'s and the logic. 
I'll take care of this in a separate issue.

> CompositeNodeStore does not dispatch external events to observers
> -----------------------------------------------------------------
>
>                 Key: OAK-7710
>                 URL: https://issues.apache.org/jira/browse/OAK-7710
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: composite
>            Reporter: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.10
>
>         Attachments: OAK-7710.patch, OAK-7710.test.patch
>
>
> Currently {{CompositeNodeStore}} only ever dispatches changes from inside its 
> {{merge}} method. This then loses external events that could be read in 
> background read of some underlying {{DocumentNodeStore}}.
> [^OAK-7710.test.patch] has an ignored test representing the scenario.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to