[
https://issues.apache.org/jira/browse/OAK-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610346#comment-16610346
]
Michael Dürig commented on OAK-7722:
------------------------------------
[~amitjain], looks good so far. Please don't forget to annotate
{{FileStore#collectBlobReferences}} with {{@Override}}.
On a more general note, I would prefer if we could remove the asymmetry of the
{{collectBlobReferences}} implementations: one delegating the a garbage
collector the other one implemented ad-hoc. Maybe we need to factor out the
blob gc concern into its own class that can be used from both places.
[~frm], WDYT? Or am I too picky here?
> Support collectBlobReferences in ReadOnlyFileStore
> --------------------------------------------------
>
> Key: OAK-7722
> URL: https://issues.apache.org/jira/browse/OAK-7722
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: segment-tar
> Reporter: Amit Jain
> Priority: Major
> Fix For: 1.10
>
> Attachments: OAK-7722.patch, OAK-7722_v2.patch
>
>
> Currently, to collect all external blob references for the {{Mark}} phase of
> DSGC, we need to open the segment store in a read-write mode i.e. use
> FileStore instead of a ReadOnlyFileStore. The task is to implement the
> \{{collectBlobReferences}} method in the \{{ReadOnlyFileStore}}.
> The references being returned might be somewhat stale in this case but by not
> much.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
