[ 
https://issues.apache.org/jira/browse/OAK-7854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660539#comment-16660539
 ] 

Francesco Mari commented on OAK-7854:
-------------------------------------

I'm in favour with the approach implemented at 
[6be30670810357bedb622ec1536dc512922e43de|https://github.com/mduerig/jackrabbit-oak/commit/6be30670810357bedb622ec1536dc512922e43de].
 As discussed offline, I would also add a timer to measure the duration of 
every flush. The duration is important to explain low flush rates: is the rate 
low because of a faulty JVM thread or because the storage is too slow?

> Add liveliness monitoring for FileStore background operations  
> ---------------------------------------------------------------
>
>                 Key: OAK-7854
>                 URL: https://issues.apache.org/jira/browse/OAK-7854
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Major
>             Fix For: 1.10
>
>
> The FileStore background operations are ultimately executed through a 
> {{ScheduledExecutorService}}. In the case this scheduling gets blocked (e.g. 
> because of a deadlock or lock contention in one of its tasks) there is chance 
> of repository corruption. 
> To minimise potential data loss we should implement monitoring endpoints for 
> the vital background operations. This would allow deployments to take action 
> early in case of failures and thus minimise potential data loss and simplify 
> recovery.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to