[
https://issues.apache.org/jira/browse/OAK-7910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16694833#comment-16694833
]
Thomas Mueller commented on OAK-7910:
-------------------------------------
Interestingly, no test case in the composite node store is failing if I change
the code to the following. Looks like this is not property tested.
{noformat}
--- src/main/java/org/apache/jackrabbit/oak/composite/CompositeNodeBuilder.java
(revision 1847115)
+++ src/main/java/org/apache/jackrabbit/oak/composite/CompositeNodeBuilder.java
(working copy)
@@ -227,9 +227,12 @@
throw new IllegalStateException("This builder does not exist: " +
PathUtils.getName(getPath()));
}
String childPath = simpleConcat(getPath(), name);
- final MountedNodeStore childStore = ctx.getOwningStore(childPath);
+ MountedNodeStore childStore = ctx.getOwningStore(childPath);
if (childStore != ctx.getGlobalStore() &&
!nodeBuilders.get(childStore).exists()) {
- throw new IllegalStateException("The mount root doesn't exist: " +
getPath() + " for " + childStore);
+ // if it doesn't exist in the read-only repository, create it in
the global repository
+ // (needed for example for a new index)
+ childStore = ctx.getGlobalStore();
}
final NodeBuilder childBuilder =
nodeBuilders.get(childStore).setChildNode(name, nodeState);
{noformat}
> Composite node store: Creating a new Lucene index; reindex
> ----------------------------------------------------------
>
> Key: OAK-7910
> URL: https://issues.apache.org/jira/browse/OAK-7910
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: composite, core
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Major
>
> With the composite node store, creating a Lucene index in the read-write
> repository fails due to the exception below. I think Oak shouldn't try to do
> node type validation for hidden nodes.
> {noformat}
> Caused by: org.apache.jackrabbit.oak.api.CommitFailedException:
> OakConstraint0001: /oak:index/test/:oak:mount-libs-index-data[[]]: The
> primary type null does not exist
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor$1.onConstraintViolation(TypeEditor.java:109)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.constraintViolation(TypeEditor.java:234)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.createEffectiveType(TypeEditor.java:337)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.<init>(TypeEditor.java:203)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.checkNodeTypeConstraints(TypeEditor.java:482)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.enter(TypeEditor.java:276)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.VisibleEditor.enter(VisibleEditor.java:53)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.CompositeEditor.enter(CompositeEditor.java:65)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeAdded(EditorDiff.java:121)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.composite.CompositeNodeState$WrappingDiff.childNodeAdded(CompositeNodeState.java:304)
> [org.apache.jackrabbit.oak-store-composite:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.composite.CompositeNodeState$ChildrenDiffFilter.childNodeAdded(CompositeNodeState.java:247)
> [org.apache.jackrabbit.oak-store-composite:1.9.10.R1845889]
> Caused by: org.apache.jackrabbit.oak.api.CommitFailedException:
> OakConstraint0001: /oak:index/test/:oak:mount-libs-index-data[[]]: The
> primary type null does not exist
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor$1.onConstraintViolation(TypeEditor.java:109)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.constraintViolation(TypeEditor.java:234)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.createEffectiveType(TypeEditor.java:337)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.<init>(TypeEditor.java:203)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.checkNodeTypeConstraints(TypeEditor.java:482)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.plugins.nodetype.TypeEditor.enter(TypeEditor.java:276)
> [org.apache.jackrabbit.oak-core:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.VisibleEditor.enter(VisibleEditor.java:53)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.CompositeEditor.enter(CompositeEditor.java:65)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.spi.commit.EditorDiff.childNodeAdded(EditorDiff.java:121)
> [org.apache.jackrabbit.oak-store-spi:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.composite.CompositeNodeState$WrappingDiff.childNodeAdded(CompositeNodeState.java:304)
> [org.apache.jackrabbit.oak-store-composite:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.composite.CompositeNodeState$ChildrenDiffFilter.childNodeAdded(CompositeNodeState.java:247)
> [org.apache.jackrabbit.oak-store-composite:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.segment.MapRecord$4.childNodeAdded(MapRecord.java:443)
> [org.apache.jackrabbit.oak-segment-tar:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:505)
> [org.apache.jackrabbit.oak-segment-tar:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.segment.MapRecord.compare(MapRecord.java:440)
> [org.apache.jackrabbit.oak-segment-tar:1.9.10.R1845889]
> at
> org.apache.jackrabbit.oak.segment.SegmentNodeState.compareAgainstBaseState(SegmentNodeState.java:651)
> [org.apache.jackrabbit.oak-segment-tar:1.9.10.R1845889]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
