[
https://issues.apache.org/jira/browse/OAK-7719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Francesco Mari resolved OAK-7719.
---------------------------------
Resolution: Fixed
Fix Version/s: 1.9.14
Fixed at r1850238.
> CheckCommand should consistently use an alternative journal if specified
> ------------------------------------------------------------------------
>
> Key: OAK-7719
> URL: https://issues.apache.org/jira/browse/OAK-7719
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: run, segment-tar
> Reporter: Francesco Mari
> Assignee: Francesco Mari
> Priority: Major
> Labels: technical_debt
> Fix For: 1.10, 1.9.14
>
>
> Callers of the {{check}} command can specify an alternative journal with the
> {{\-\-journal}} option. This option instructs the {{ConsistencyChecker}} to
> check the revisions stored in that file instead of the ones stored in the
> default {{journal.log}}.
> I spotted at least two problems while using {{\-\-journal}} on a repository
> with a corrupted {{journal.log}} that didn't contain any valid revision.
> First, the path to the {{FileStore}} is validated by
> {{FileStoreHelper#isValidFileStoreOrFail}}, which checks for the existence of
> a {{journal.log}} in the specified folder. But if a {{journal.log}} doesn't
> exist and the user specified a different journal on the command line this
> check should be ignored.
> Second, when opening the {{FileStore}} the default {{journal.log}} is scanned
> to determine the initial revision of the head state. If a user specifies an
> alternative journal on the command line, that journal should be used instead
> of the default {{journal.log}}. It might be that the default journal contains
> no valid revision, which would force the system to crash when opening a new
> instance of {{FileStore}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
