[ 
https://issues.apache.org/jira/browse/OAK-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777050#comment-16777050
 ] 

Axel Hanikel commented on OAK-8071:
-----------------------------------

[~mduerig] I've made a few changes in 
[https://github.com/ahanikel/jackrabbit-oak/commits/OAK-8071] :
 * Cosmetic change: Renamed variable "w" to "k" because I couldn't figure out 
what "w" stands for ;)
 * I think {{currentCommit}} should be volatile because it is probably called 
from a different thread via {{#getCurrentWriter}} (although it's probably not a 
big issue).
 * I've tried to add the full GC generation to the {{CommitsTracker}} (but it's 
not reflected in the {{SegmentNodeStoreStats}} yet). Perhaps you can quickly 
check if what I did makes any sense...

Next steps:
 * Add the generation to the {{SegmentNodeStoreStats}}.
 * The {{CommitsTrackerTest}} (both tests) are failing for me. I'm going to 
figure out why.

> Logging to detect commits carrying over from previous GC generation can block 
> other threads from committing
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-8071
>                 URL: https://issues.apache.org/jira/browse/OAK-8071
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Blocker
>             Fix For: 1.12, 1.11.0, 1.8.12, 1.10.2
>
>
> Add logging / monitoring to detect the situation from OAK-8014.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to