[
https://issues.apache.org/jira/browse/OAK-8111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16786128#comment-16786128
]
Vikas Saurabh edited comment on OAK-8111 at 3/6/19 8:58 PM:
------------------------------------------------------------
Talked to [~reschke] (jira doesn't seem to be working for him) and it seems I
created some confusion as I was looking at the patch in context of this issue.
What I was arguing was that for this issue, readOnly/read-write should be
"implied" like dryRun.
[~reschke] pointed me to the fact that I was trying to touch on arg parsing in
the patch is common change to node store builder and hence isn't bound to this
particular issue.
So, here's another go at a proposal:
* I feel that option parsing should default to read-only and go read-write only
if defined explicitly. This would be a breaking change but if we log sufficient
information about how to enable read-write mode (as we do for oak-run console)
I think we should be ok. My reasoning to tend towards default read-only is that
we won't accidentally write to a repo
* in context of this issue - I think dryRun should define whether node store is
initialized as read-only as ead-write. Explicitly requiring another flag isn't
useful in either case (dryRun should be read-only... non-dryRun needs to write
anyway in almost all cases)
was (Author: catholicon):
Talked to [~reschke] (jira doesn't seem to be working for me) and it seems I
created some confusion as I was looking at the patch in context of this issue.
What I was arguing was that for this issue, readOnly/read-write should be
"implied" like dryRun.
[~reschke] pointed me to the fact that I was trying to touch on arg parsing in
the patch is common change to node store builder and hence isn't bound to this
particular issue.
So, here's another go at a proposal:
* I feel that option parsing should default to read-only and go read-write only
if defined explicitly. This would be a breaking change but if we log sufficient
information about how to enable read-write mode (as we do for oak-run console)
I think we should be ok. My reasoning to tend towards default read-only is that
we won't accidentally write to a repo
* in context of this issue - I think dryRun should define whether node store is
initialized as read-only as ead-write. Explicitly requiring another flag isn't
useful in either case (dryRun should be read-only... non-dryRun needs to write
anyway in almost all cases)
> Create read-only DocumentNodeStore for oak-run recovery dry run
> ---------------------------------------------------------------
>
> Key: OAK-8111
> URL: https://issues.apache.org/jira/browse/OAK-8111
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: oak-run
> Reporter: Marcel Reutegger
> Assignee: Julian Reschke
> Priority: Minor
> Labels: candidate_oak_1_10, candidate_oak_1_8
> Fix For: 1.12
>
> Attachments: OAK-8111.diff, OAK-8111.diff
>
>
> The oak-run recovery command always creates a read-write DocumentNodeStore
> even when the dryRun flag is set. In dryRun mode, the command should create a
> read-only DocumentNodeStore.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
