[
https://issues.apache.org/jira/browse/OAK-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795074#comment-16795074
]
Marcel Reutegger commented on OAK-8113:
---------------------------------------
I like the indirection this adds to make the dependencies optional. However,
you are right, the size of those additional jar files are indeed rather small
and in my view not a big issue.
With the use case you explained, moving the exporter to a separate process or
JVM agent also looks non trivial. IIUC the problem is, you only want to push
metrics at the end of the command. This requires coordination between the
command and the exporter, which is what your patch does with the close() call
to the MetricsExporterFixture. Given the size of those libraries and the added
complexity of your second patch, I'm not sure which one is the better option. I
think, I'm fine either way.
Alternatively, what if oak-run had an option to write metrics to stdout or a
file in a well defined format after the command finished? E.g. a json file,
which then can be post processed by a tool of your choice and push the data to
e.g. Prometheus.
> Add ability to push metrics to prometheus pushgateway from oak-run
> ------------------------------------------------------------------
>
> Key: OAK-8113
> URL: https://issues.apache.org/jira/browse/OAK-8113
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: oak-run
> Reporter: Amit Jain
> Assignee: Amit Jain
> Priority: Major
> Fix For: 1.12
>
> Attachments: OAK-8113.patch, OAK-8113_v2.patch
>
>
> Currently, metrics capturing is supported in oak-run but these are not
> exported. If some important tasks like DSGC are run outside of the server
> using oak-run then it would be helpful help if these important metrics
> captured, can be pushed to an external system if available and from where any
> reporting can be developed.
> This task is specifically meant for prometheus pushgateway
> https://github.com/prometheus/client_java though there are some other export
> options also available.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
