[
https://issues.apache.org/jira/browse/OAK-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795976#comment-16795976
]
Thomas Mueller commented on OAK-8138:
-------------------------------------
[~nitigup] the patch looks good to me! It's good to have this well tested. I
can't comment if the changes are correct (featurewise).
Only one line of code where I ask you to change spacing. Could you add spaces
after commas please, and remove the space before the end ')'?
{noformat}
now:
return getFacets(searcher, query, plan,
secureFacetConfiguration,searcher.search(query,1).totalHits );
new:
return getFacets(searcher, query, plan, secureFacetConfiguration,
searcher.search(query, 1).totalHits);
{noformat}
I might just be me, but I prefer consistent code style when reading... missing
spaces distract me...
> In cases where search hit count is less than sample size defined for
> statistical mode for facets, secure mode should be used so that the counts
> are accurate for non-admin users.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OAK-8138
> URL: https://issues.apache.org/jira/browse/OAK-8138
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: query, search
> Reporter: Nitin Gupta
> Priority: Major
>
> In cases where search hit count is less than sample size defined for
> statistical mode for facets, secure mode should be used so that the counts
> are accurate for non-admin users.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
