[ 
https://issues.apache.org/jira/browse/OAK-8177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807758#comment-16807758
 ] 

Thomas Mueller commented on OAK-8177:
-------------------------------------

I don't think the comment "// Additional logging needed for <OAK-8177>" is 
needed.

One problem is that the log message is exactly the same in two locations of the 
code:

{noformat}
Checkpoint {} doesn't exist. Debug info:\n{}
{noformat}

You have changed one such case (added the stack trace), but not the other. It's 
probably better (safer) to change both cases.



> Add logging around getReferenceCheckpoint method 
> -------------------------------------------------
>
>                 Key: OAK-8177
>                 URL: https://issues.apache.org/jira/browse/OAK-8177
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: composite, lucene
>            Reporter: Nitin Gupta
>            Priority: Major
>         Attachments: OAK-8177_1.patch, OAK-8177_2.patch
>
>
> 04.03.2019 06:42:46.956 *WARN* 
> [sling-oak-3-org.apache.jackrabbit.oak.plugins.index.AsyncIndexUpdate-async] 
> org.apache.jackrabbit.oak.composite.CompositeNodeStore Checkpoint 
> f7e6524d-62c4-4589-8137-ca873cec934b doesn't exist
> The above warning was observed - but there are not enough logs around this to 
> identify what's causing this .
>  
> We need to add stack trace when this is logged and probably changed the 
> message to make it unique.
>  
> Also , Since this was logged from a flow in AsyncIndexUpdate - It would make 
> sense to add some more info/ warn level logging there around the code that 
> calls getReferenceCheckpoint()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to