[
https://issues.apache.org/jira/browse/OAK-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814376#comment-16814376
]
Alex Deparvu commented on OAK-8209:
-----------------------------------
I think the test is too weak to represent normal operations. The tree will
probably be valid as long as the NodeState will be available. If I remember
correctly from back in the day, you can get into trouble keeping a tree
reference over a compaction run (you'd start seeing SNFEs), but that might not
be true anymore. And this is of course segment store, for the document store
you are the expert :)
In general, a session will get refreshed, but a hard reference to a tree will
not, hence my suggestion to set the tree to null on {{refresh}}, does that not
fare well with the benchmark?
> Improve Node.isNodeType(String) performance
> -------------------------------------------
>
> Key: OAK-8209
> URL: https://issues.apache.org/jira/browse/OAK-8209
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: jcr
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Minor
> Attachments: OAK-8209-RootTest.patch
>
>
> Profiling an application running on Oak showed calls to
> {{Node.isNodeType(String)}} as one of the hot spots. While it may be possible
> to reduce those calls there's probably also some potential in optimizing the
> implementation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
