[ 
https://issues.apache.org/jira/browse/OAK-8232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16817642#comment-16817642
 ] 

Alex Deparvu commented on OAK-8232:
-----------------------------------

I think the type existence check already happens a few lines above [0], there's 
no need to redo it.
Re. location of the code, I think parts of this should move to the 
NodeDelegate, but it might be simpler to keep this change focused on the bug 
itself and refactor later.

[0] 
https://github.com/apache/jackrabbit-oak/blob/trunk/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java#L1357

> Node#setPrimaryType(String) does not create child nodes defined as autoCreated
> ------------------------------------------------------------------------------
>
>                 Key: OAK-8232
>                 URL: https://issues.apache.org/jira/browse/OAK-8232
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>    Affects Versions: 1.12.0
>            Reporter: Manfred Baedke
>            Priority: Minor
>         Attachments: oak-8232-testcase.patch, oak-8232.patch
>
>
> In contrast to Node#addNode(String, String), Node#setPrimaryType(String) does 
> not create child nodes that are defined as autoCreated. See attached failing 
> test case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to