[ 
https://issues.apache.org/jira/browse/OAK-8139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821072#comment-16821072
 ] 

Stefan Egli commented on OAK-8139:
----------------------------------

[~reschke] sorry for the delay and thanks for looking at this! It does fix the 
original problem with {{-SNAPSHOT}} however in theory the version could also be 
something like {{1.7.9-R1234567}}. I've added  [^OAK-8139.patch2.diff] with a 
suggested. Wdyt?

> DocumentDiscoveryLiteService hasBacklog silencing must support maven version 
> format
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-8139
>                 URL: https://issues.apache.org/jira/browse/OAK-8139
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>            Reporter: Stefan Egli
>            Assignee: Julian Reschke
>            Priority: Minor
>              Labels: candidate_oak_1_6
>             Fix For: 1.8.13, 1.10.3, 1.14.0
>
>         Attachments: OAK-8139.diff, OAK-8139.patch2.diff
>
>
> OAK-3492 silences log warns when it encounters an 1.0 or 1.2 oak version (in 
> the case where there is an inactive cluster node that doesn't have 
> lastWrittenRootRev set).
> The silencing uses osgi Version to do the version comparison, however the 
> actual version is stored in maven format. This breaks for eg the case where 
> version is set to something like 1.0.10-SNAPSHOT where it expects 
> 1.0.10.SNAPSHOT and the following exception would occur:
> {{org.apache.jackrabbit.oak.plugins.document.DocumentDiscoveryLiteService 
> hasBacklog: couldn't parse version 1.0.10-SNAPSHOT : 
> java.lang.IllegalArgumentException: invalid version "1.0.10-SNAPSHOT": 
> non-numeric "10-SNAPSHOT"}}
> The silencing should be fixed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to