[jira] [Commented] (OAK-8258) Active deletion can delete blobs despite indexing cycle deleting them failed

[Thomas Mueller (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OAK-8258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835368#comment-16835368
 ] 

Thomas Mueller commented on OAK-8258:
-------------------------------------

As an alternative to catching Throwable what about setting indexingFailed = 
true by default, and only set it to false if indexing worked? Actually maybe 
clearer to use the reverse: indexingSuccess:

{noformat}
boolean indexingSuccess = false;
try {
    ...
    indexingSuccess = true;
} finally {
   ....
}
{noformat}


> Active deletion can delete blobs despite indexing cycle deleting them failed
> ----------------------------------------------------------------------------
>
>                 Key: OAK-8258
>                 URL: https://issues.apache.org/jira/browse/OAK-8258
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: lucene
>    Affects Versions: 1.12.0, 1.8.12, 1.10.2
>            Reporter: Vikas Saurabh
>            Assignee: Vikas Saurabh
>            Priority: Major
>             Fix For: 1.8.13, 1.10.3, 1.14.0
>
>
> Essentially OAK-6270 always reports successful commit even in case of failures



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)