[
https://issues.apache.org/jira/browse/OAK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836761#comment-16836761
]
Henry Saginor commented on OAK-8275:
------------------------------------
{quote}Thanks for clarifying. The 2GB limit indeed is bad. But as you
mentioned, we can always get a new InputStream from Binary.
{quote}
That is what I am doing indeed. :)
{quote}FWIW, whether setting a huge readlimit will cause memory issues solely
depends on the input stream implementation, right?
{quote}
I am not sure I guess and it would have to be tested. But I imagine
implementations having some internal buffer that is of readlimit size. That's
why I think it could cause memory issues.
> Add NIO channel access to JCR binaries
> --------------------------------------
>
> Key: OAK-8275
> URL: https://issues.apache.org/jira/browse/OAK-8275
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Reporter: Henry Saginor
> Priority: Major
>
> This is a follow up to the discussion started in OAK-8186. Currently JCR
> binaries can only be accessed via InputStream. This is inefficient. It can
> also be inadequate for some use cases. For example handling some Zip file
> formats like deflate64 requires random access.
> The proposal is to add API that returns SeekableByteChannel
> Here is the new API I am proposing -
>
> [https://github.com/hsaginor/jackrabbit/blob/createChannel/jackrabbit-api/src/main/java/org/apache/jackrabbit/api/ChannelBinary.java]
>
> [https://github.com/hsaginor/jackrabbit-oak/blob/createChannel2/oak-api/src/main/java/org/apache/jackrabbit/oak/api/Blob.java]
> (see 2 added methods)
> And all of the implementation changes -
>
> [https://github.com/apache/jackrabbit-oak/compare/trunk...hsaginor:createChannel2]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
