[
https://issues.apache.org/jira/browse/OAK-8294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841038#comment-16841038
]
Thomas Mueller commented on OAK-8294:
-------------------------------------
[~catholicon] sorry for the delay.
> exact string matches
I see. I would be very user-friendly I agree, on the other hand it is less
flexible... In your example, in theory the "AND [foo]=" could be in quotes, so
by mistake it would also match for example
{noformat}
SELECT * FROM [some:Type] WHERE [rel/path/foo]=' some test AND [foo]='' some
other text '
{noformat}
I know regular expressions are not very user friendly and tricky to get
right... But flexible.
That said, I will try to implement your approach as well, I think it would be
so much easier. Meaning, try to support both regular expressions as well as
patterns as you describe.
> Make it possible to mark a (customer) query as bad and skip it
> --------------------------------------------------------------
>
> Key: OAK-8294
> URL: https://issues.apache.org/jira/browse/OAK-8294
> Project: Jackrabbit Oak
> Issue Type: New Feature
> Components: query
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Priority: Major
> Attachments: OAK-8294.patch
>
>
> Application code can run all kinds of bad queries (reading a lot of data,
> slow, high memory usage).
> The best solution is to fix the application of course. But that can take a
> while, and until this is done, it would be good if bad queries can be blocked
> in another way. Problematic queries would either just log a warning, or be
> blocked (throw an exception when trying to run).
> Blocking should be possible via JMX, but also via persistent configuration
> (in the repository), so that a restart remembers which queries are blocked.
> I don't think it's needed to stop already running queries, as the traversal
> limit should solve this (it can be re-configured at runtime if needed). Also,
> reading the patterns from the repository is only needed at startup (while
> running, JMX can be used to temporarily add patterns).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
