[ 
https://issues.apache.org/jira/browse/OAK-8629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16933105#comment-16933105
 ] 

Chetan Mehrotra commented on OAK-8629:
--------------------------------------

Would have a closer look. Note that currently nodeType change with bundling is 
not properly handled. There is a TODO left in 
[CommitDiff|https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/CommitDiff.java#L100]

{noformat}
    @Override
    public boolean childNodeChanged(String name,
                                    NodeState before,
                                    NodeState after) {
        //TODO [bundling] Handle change of primaryType. Current approach would 
work
        //but if bundling was enabled for previous nodetype its "side effect"
        //would still impact even though new nodetype does not have bundling 
enabled
        BundlingHandler child = bundlingHandler.childChanged(name, before, 
after);
        return after.compareAgainstBaseState(before,
                new CommitDiff(store, commit, child, builder, blobs));
    }
{noformat}

Problem here is that nodeType change would not result in deletion and 
recreation. Hence Bundling logic would still need to be activated as underlying 
structure is still bundled.

> Node bundling exposes hidden properties
> ---------------------------------------
>
>                 Key: OAK-8629
>                 URL: https://issues.apache.org/jira/browse/OAK-8629
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>    Affects Versions: 1.16.0
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>             Fix For: 1.18.0
>
>         Attachments: OAK-8629.patch
>
>
> The DocumentNodeStore node bundling feature may expose a hidden internal 
> property when a bundled node structure is deleted and re-created with a 
> non-bundling nodetype.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to