[
https://issues.apache.org/jira/browse/OAK-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937768#comment-16937768
]
Stefan Egli commented on OAK-8593:
----------------------------------
+1, lgtm.
some minor comments:
* What might be slightly non-obvious is that the read-only DocumentNodeStore
(created via {{ClusterNodeInfo.getReadOnlyInstance()}}) is created with
{{invisible=false}}. I guess it doesn't matter much how the invisible flag is
set for read-only as it's mostly (only?) used for testing (presumably a stack
above Oak, when in read-only mode, wouldn't hold back with writing...)
* A comment about using {{invisible}} with Sling Discovery: as long as the
invisible use case is limited to oak - eg via oak-run as is the case IIUC -
then things are fine. Should we consider at some point extending this to the
full stack, ie adding Sling Discovery in the picture, that won't work anymore.
Sling Discovery will expect the local (own) instance to always be part of a
cluster - it doesn't know anything about and thus doesn't support "being
invisible". Just something we have to keep in mind, nothing to be worried at
this point.
> Enable a transient cluster-node to connect as invisible to oak discovery
> ------------------------------------------------------------------------
>
> Key: OAK-8593
> URL: https://issues.apache.org/jira/browse/OAK-8593
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
> Reporter: Amit Jain
> Assignee: Amit Jain
> Priority: Major
> Attachments: OAK-8593.patch
>
>
> Currently, if Oak is initialized with read-write access to the DocumentStore
> (Mongo/RDB) e.g through oak-run, it is made visible to upper layers (e.g.
> sling discovery) via the oak discovery cluster view. This can cause problems
> in the actual cluster with the differing topology view and the capabilities
> advertised and in some circumstances being made a leader.
> In an offline discussion with [~mreutegg] and [~egli] it was decided that its
> best to expose a flag \{{invisible}} in the cluserNodes collection/table with
> which these instances can connect and then these would be ignored by the oak
> discovery.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
