[ 
https://issues.apache.org/jira/browse/OAK-8783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16984846#comment-16984846
 ] 

Nitin Gupta commented on OAK-8783:
----------------------------------

[~thomasm] - looks good to me .

Just a couple of small comments -

In the test method newObjectRespectingOrder the comment // we expect it's a 
HashMap should be // we expect it's a LinkedHashMap I suppose ?

 

Also , for the test case newObjectNotRespectingOrder, since properties would be 
a plain hashmap here - can we expect it to always return the same result every 
time the test is run ? What I mean to say is, since a hashmap doesn't maintains 
insertion order, wouldn't it be possible that sometimes in the test run it 
might return the correct insertion order too and the test would fail in that 
run ?

> Merge index definitions
> -----------------------
>
>                 Key: OAK-8783
>                 URL: https://issues.apache.org/jira/browse/OAK-8783
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Thomas Mueller
>            Assignee: Thomas Mueller
>            Priority: Major
>         Attachments: OAK-8783-json-1.patch, OAK-8783-v1.patch
>
>
> If there are multiple versions of an index, e.g. asset-2-custom-2 and 
> asset-3, then oak-run should be able to merge them to asset-3-custom-1.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to