[ 
https://issues.apache.org/jira/browse/OAK-8914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040785#comment-17040785
 ] 

Marcel Reutegger commented on OAK-8914:
---------------------------------------

[~vholani], thanks for the patch. Is there a particular reason why the Revision 
GC started via the MBean does not respect the configured delay factor?

Could you please also add a test in DocumentNodeStoreServiceTest to check 
whether a non-default config value is picked up by 
{{DocumentNodeStore.getVersionGarbageCollector().getVersionGCOptions()}}?

Other than that, the patch looks good to me.

> Throttle Revision GC
> --------------------
>
>                 Key: OAK-8914
>                 URL: https://issues.apache.org/jira/browse/OAK-8914
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: documentmk
>            Reporter: Vinod Holani
>            Assignee: Marcel Reutegger
>            Priority: Minor
>         Attachments: OAK-8914.patch
>
>
> Currently the Revision GC is allowed to run at full speed. In some cases the 
> load caused by the Revision GC can be very high and potentially overwhelm the 
> MongoDB cluster. The high Revision GC activity tends to be higher than usual 
> when it was skipped for a longer period of time, e.g. because there is a 
> checkpoint that prevents it from collecting garbage.
> Consider throttling the Revision GC. The implementation already has some 
> support for throttling. SeeĀ {{VersionGCOptions.delayFactor}}. However, there 
> is currently no configuration option in the DocumentNodeStoreService.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to