[ 
https://issues.apache.org/jira/browse/OAK-8995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084524#comment-17084524
 ] 

Nitin Gupta commented on OAK-8995:
----------------------------------

[[email protected]] , [~mkataria]  - there seems some problem with 
the file removals. 

Notice 
[https://github.com/apache/jackrabbit-oak/blob/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score/ScorerProvider.java]
 is still present as an empty file.

If I notice the svn update logs, it shows these files as updated and not 
removed -
{code:java}
U    
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\ScorerProvider.java
U    
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\ScorerProviderFactory.java
U    
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\impl\ScorerProviderFactoryImpl.java
U    
oak-lucene\src\main\java\org\apache\jackrabbit\oak\plugins\index\lucene\score\package-info.java

{code}
As a result rat check fails.

Try doing a mvn clean install -Prat in  oak-lucene.

> Remove support for lucene custom scorer
> ---------------------------------------
>
>                 Key: OAK-8995
>                 URL: https://issues.apache.org/jira/browse/OAK-8995
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: lucene, oak-search
>            Reporter: Fabrizio Fortino
>            Priority: Major
>             Fix For: 1.28.0
>
>         Attachments: OAK-8995-1.patch, OAK-8995-2.patch
>
>
> The custom scorer exposes the Lucene API directly. This needs to be removed 
> in order to support remote index services (solr, elasticsearch). Since this 
> feature does not seem to be used, we can safely remove it.
>  
> [https://github.com/apache/jackrabbit-oak/tree/trunk/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/score]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to