[
https://issues.apache.org/jira/browse/OAK-9246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marcel Reutegger reopened OAK-9246:
-----------------------------------
Reopening because there are test failures. See OAK-9313.
In addition, the class LoginModuleMonitorTest is missing the license header.
Apologies, I didn't notice during the review.
> Avoid hardcoding stats classes in SecurityProviderRegistration
> --------------------------------------------------------------
>
> Key: OAK-9246
> URL: https://issues.apache.org/jira/browse/OAK-9246
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, security, security-spi
> Reporter: Angela Schreiber
> Assignee: Angela Schreiber
> Priority: Major
> Fix For: 1.38.0
>
> Attachments: OAK-9246.patch
>
>
> OAK-8102 introduce a single {{LoginModuleStats}} to collect unexpected errors
> during the repository login. the corresponding monitor and mbeans are
> registered in the {{SecurityProviderRegistration}} after creating the
> {{SecurityProvider}} instance.
> instead of 'hardcoding' the stats in {{SecurityProviderRegistration}}, i
> would suggest to come up with a mechanism that allows individual security
> modules to register statistics related monitors and mbeans as needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
