[ 
https://issues.apache.org/jira/browse/OAK-9331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269256#comment-17269256
 ] 

Andrei Dulceanu commented on OAK-9331:
--------------------------------------

Applying [^OAK-9331-01.patch] almost all issues go away, except this one:
{noformat}
 [ERROR] Exit code: 1 - 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:23:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocument;
[ERROR]                                                             ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:24:
 error: ElasticDocumentMaker is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocumentMaker;
[ERROR]                                                             ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:44:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]     private final FulltextIndexWriter<ElasticDocument> indexWriter;
[ERROR]                                       ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:48:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]                           FulltextIndexWriter<ElasticDocument> 
indexWriter) {
[ERROR]                                               ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:110:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]     private void writeToIndex(ElasticDocument doc, String path) throws 
IOException {
[ERROR]                               ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexer.java:114:
 error: ElasticDocumentMaker is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]     private ElasticDocumentMaker 
newDocumentMaker(IndexDefinition.IndexingRule indexingRule, String path) {
[ERROR]             ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:25:
 error: ElasticDocument is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticDocument;
[ERROR]                                                             ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:26:
 error: ElasticIndexWriterFactory is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR] import 
org.apache.jackrabbit.oak.plugins.index.elastic.index.ElasticIndexWriterFactory;
[ERROR]                                                             ^
[ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-run-elastic/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/ElasticIndexerProvider.java:47:
 error: ElasticIndexWriterFactory is not public in 
org.apache.jackrabbit.oak.plugins.index.elastic.index; cannot be accessed from 
outside package
[ERROR]     private final ElasticIndexWriterFactory indexWriterFactory;
[ERROR]                   ^
[ERROR]
[ERROR] Command line was: 
/Library/Java/JavaVirtualMachines/zulu-15.jdk/Contents/Home/bin/javadoc 
@options @packages{noformat}
[~fabrizio.fort...@gmail.com], could you take a look at it, please? Once the 
issue spotted, you could add a patch to this issue (not applying the changes on 
trunk yet, see below).

OTOH, it seems that the changes done to be Java 15 compliant are not backwards 
compatible, therefore when attempting {{mvn javadoc:javadoc}} with Java 8 I get 
this:
{noformat}
 [ERROR] 
/Users/dulceanu/projects/apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
 error: header used out of sequence: <H4>
[ERROR]      * <h4>Backwards compatibility with Jackrabbit 2.x</h4>{noformat}
Any thoughts on how to proceed with this? Should we leave everything as is and 
be able to generate JavaDocs for Java 8?

/cc [~mreutegg]

> JavaDoc generation fails on Java 15
> -----------------------------------
>
>                 Key: OAK-9331
>                 URL: https://issues.apache.org/jira/browse/OAK-9331
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Major
>         Attachments: OAK-9331-01.patch
>
>
> {{mvn javadoc:javadoc}} fails on Java 15 with:
> {noformat}
> /apache/jackrabbit-oak/oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalConfiguration.java:48:
>  error: unexpected heading used: <H3>, compared to implicit preceding 
> heading: <H3>
> [ERROR]      * <h3>Backwards compatibility with Jackrabbit 2.x</h3>
> [ERROR]        ^
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to