[
https://issues.apache.org/jira/browse/OAK-9342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281719#comment-17281719
]
Stefan Egli commented on OAK-9342:
----------------------------------
+1, agree, collecting invalidation paths is superfluous work when invoked as
part of {{diffImpl}} - it basically just collects the paths then throws them
away via a friendly {{close()}}. Invalidation paths are only needed/processed
by {{backgroundRead}}.
> JournalDiffLoader should ignore linked invalidation entries
> -----------------------------------------------------------
>
> Key: OAK-9342
> URL: https://issues.apache.org/jira/browse/OAK-9342
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: documentmk
> Reporter: Marcel Reutegger
> Assignee: Marcel Reutegger
> Priority: Major
>
> The JournalDiffLoader reads journal documents to identify paths that have
> been changed between two given revisions. It uses the JournalEntry to read
> those changes. The latter class always resolves linked invalidation journal
> entries. This is necessary for the background read to invalidate documents in
> the cache, but unnecessary for the JournalDiffLoader use case.
> The {{invalidate}} parameter of {{JournalEntry.fillExternalChanges()}} should
> become optional.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
