[ 
https://issues.apache.org/jira/browse/OAK-7182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364619#comment-17364619
 ] 

Aaron Anderson commented on OAK-7182:
-------------------------------------

Thanks for all of the excellent work on this issue. I am able to run the AWS 
SegmentNodeStore with the latest version of Oak (1.40) and Guava without any 
problem. 

I have encountered a few incompatibilities when using the RDMDocumentStore 
though. 

org.apache.jackrabbit.oak.plugins.document.DocumentNodeStoreBuilder -> needs a 
method update from 
com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor to 
com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService

org.apache.jackrabbit.oak.cache.AbstractCacheStats and 
org.apache.jackrabbit.oak.plugins.blob.StagingCacheStats -> needs a class 
update from com.google.common.base.Objects.toStringHelper to  
com.google.common.base.MoreObjects.toStringHelper

 

In my application I am using ASM to correct these minor incompatibilities in 
the bytecode. Since "36. Remove (Guava) 
com.google.common.base.Objects.ToStringHelper" has been done elsewhere perhaps 
a quick change can be made to the CacheStats classes and the sameThreadExecutor 
utility could possibly be replaced with something simple like [this 
Camel|https://github.com/apache/camel/blob/main/core/camel-util/src/main/java/org/apache/camel/util/concurrent/SynchronousExecutorService.java]
 class.

 

 

> Make it possible to update Guava
> --------------------------------
>
>                 Key: OAK-7182
>                 URL: https://issues.apache.org/jira/browse/OAK-7182
>             Project: Jackrabbit Oak
>          Issue Type: Wish
>            Reporter: Julian Reschke
>            Priority: Minor
>         Attachments: GuavaTests.java, OAK-7182-guava-21-3.diff, 
> OAK-7182-guava-21-4.diff, OAK-7182-guava-21.diff, OAK-7182-guava-23.6.1.diff, 
> guava.diff
>
>
> We currently rely on Guava 15, and this affects all users of Oak because they 
> essentially need to use the same version.
> This is an overall issue to investigate what would need to be done in Oak in 
> order to make updates possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to