[ 
https://issues.apache.org/jira/browse/OAK-9562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17407293#comment-17407293
 ] 

Marcel Reutegger commented on OAK-9562:
---------------------------------------

bq. Do you mean the condition "nd.hasBinary() != 1" ?

The entire condition whether to set the hasBinary (aka _bin) flag.

bq. something like this should work fine:
{noformat}
+        for (String path : this.nodesWithBinaries) {
+            NodeDocument.setHasBinary(getUpdateOperationForNode(path));
+        }
{noformat}

Yes, this is also what I had in mind. Thanks for the quick feedback. I'm 
currently testing this.

> Missing _bin when node is recreated after revision GC
> -----------------------------------------------------
>
>                 Key: OAK-9562
>                 URL: https://issues.apache.org/jira/browse/OAK-9562
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: documentmk
>    Affects Versions: 1.6.0, 1.8.0, 1.22.0, 1.40.0
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Major
>
> When a node with a binary property is recreated after a revision GC 
> operation, it may happen that the document for the node is missing the _bin 
> flag. A subsequent blob store garbage collection then removes the blob.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to