[ 
https://issues.apache.org/jira/browse/OAK-9824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17563301#comment-17563301
 ] 

Thomas Mueller commented on OAK-9824:
-------------------------------------

> the index is not necessary for indexing

Well.... it is!

The indexes is updated (written to) during indexing. (There is synchronous and 
asynchronous indexes, and so updates).

"MUST be reindexed for indexing to work properly"

That means the index needs to be re-indexed (re-built from scratch) so that it 
can be updated.

The old index might still be used for queries, if the corruption is not as bad.

Having said all that, I think the PR is fine. I don't think those fine details 
are all that important, and might be confusing.

> Confusing warning "This index MUST be reindexed for indexing to work properly"
> ------------------------------------------------------------------------------
>
>                 Key: OAK-9824
>                 URL: https://issues.apache.org/jira/browse/OAK-9824
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> The warning emitted from 
> https://github.com/apache/jackrabbit-oak/blob/871ce1bb28712c16ba75b57538fb49e14bc135a3/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/TrackingCorruptIndexHandler.java#L116
>  is incorrect, as the index is not necessary for indexing but for search. I 
> would propose to change it to "This index MUST be reindexed for search to 
> work properly" or simply "This index MUST be reindexed to work properly".



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to