[
https://issues.apache.org/jira/browse/OAK-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17705308#comment-17705308
]
Julian Reschke commented on OAK-9989:
-------------------------------------
bq. I'm in favour of moving the wrapped Guava library outside the reactor pom,
or even a dedicated git repo? It will and should have an independent release
cycle. There is also other candidate we could move: oak-doc-railroad-macro.
I'm not completely sure that a different release cycle is a good idea. It would
mean that we have yet another project that we need to manage and release
separately.
But if we do that, would we need to involve INFRA in that if we want a new repo?
bq. I would not do this, but I'm probably biased because I'm using IntelliJ and
it reads documentation from source files. So I'm happy as long as a sources jar
file is published to maven central.
Yes, with the current setup (after manually removing the project), I got
Javadoc in Eclipse as well.
bq. Why could you do this? I see two effects if we minimize the library
Size is ~ 2.5 MB, and we'll also eventually get rif of the original Guava, so
that is not an issue.
I was considering this so that we can actually limit the amount of Guava that
we support. Maybe a whole part of Guava is both not used, and we actually do
not want it to be used? - In that case, we could control that this way. But
likely this is too much maintenance effort...
> introduce oak-wrapped-guava project
> -----------------------------------
>
> Key: OAK-9989
> URL: https://issues.apache.org/jira/browse/OAK-9989
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Reporter: Julian Reschke
> Assignee: Julian Reschke
> Priority: Major
> Fix For: 1.52.0
>
> Attachments: convert-guava.sh
>
>
> Plan:
> 1. add wrapped Guava project
> 2. change all internal uses of Guava to use o.a.j.oak.guava.* (or replace by
> JDK methods)
> 3. remove all Guava uses in public APIs (separate ticket)
> Note: IDEs do not work well with the shade plugin. In Intellij, you'll have
> to disable the wrapped-guava project. In Eclipse, you even need to remove it.
> The alternative would be to move the whole subproject outside the Oak reactor
> pom (opinions?).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
