[ 
https://issues.apache.org/jira/browse/OAK-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated OAK-9989:
--------------------------------
    Description: 
Plan:

1. add shaded Guava project
2. change all internal uses of Guava to use o.a.j.oak.guava.* (or replace by 
JDK methods)
3. remove all Guava uses in public APIs (separate ticket)

Note: IDEs do not work well with the shade plugin. In Intellij, you'll have to 
"ignore" the oak-shaded-guava project ("maven" window). In Eclipse, you even 
need to remove it. The alternative would be to move the whole subproject 
outside the Oak reactor pom (opinions?).

Note 2: the current proposed patch uses Guava 20, as it is mostly (OAK-10151) 
compatible with Guava 15 and allows us to migrate away from APIs that were 
removed in version 21. Once done with that, we'd update to newer Guava 
versions. 

  was:
Plan:

1. add shaded Guava project
2. change all internal uses of Guava to use o.a.j.oak.guava.* (or replace by 
JDK methods)
3. remove all Guava uses in public APIs (separate ticket)

Note: IDEs do not work well with the shade plugin. In Intellij, you'll have to 
"ignore" the shaded-guava project ("maven" window). In Eclipse, you even need 
to remove it. The alternative would be to move the whole subproject outside the 
Oak reactor pom (opinions?).

Note 2: the current proposed patch uses Guava 20, as it is mostly (OAK-10151) 
compatible with Guava 15 and allows us to migrate away from APIs that were 
removed in version 21. Once done with that, we'd update to newer Guava 
versions. 


> introduce oak-shaded-guava project
> ----------------------------------
>
>                 Key: OAK-9989
>                 URL: https://issues.apache.org/jira/browse/OAK-9989
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Major
>             Fix For: 1.52.0
>
>         Attachments: convert-guava.sh
>
>
> Plan:
> 1. add shaded Guava project
> 2. change all internal uses of Guava to use o.a.j.oak.guava.* (or replace by 
> JDK methods)
> 3. remove all Guava uses in public APIs (separate ticket)
> Note: IDEs do not work well with the shade plugin. In Intellij, you'll have 
> to "ignore" the oak-shaded-guava project ("maven" window). In Eclipse, you 
> even need to remove it. The alternative would be to move the whole subproject 
> outside the Oak reactor pom (opinions?).
> Note 2: the current proposed patch uses Guava 20, as it is mostly (OAK-10151) 
> compatible with Guava 15 and allows us to migrate away from APIs that were 
> removed in version 21. Once done with that, we'd update to newer Guava 
> versions. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to