[ 
https://issues.apache.org/jira/browse/OAK-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740089#comment-17740089
 ] 

Manfred Baedke edited comment on OAK-10338 at 7/5/23 8:34 AM:
--------------------------------------------------------------

Tested with Java 11 and Java 20.
Note that the test result will also depend on your Git settings (config 
parameter core.autocrlf).


was (Author: baedke):
Tested with Java 11 and Java 20.
Note that the test result might also depend on your Git settings (config 
parameter core.autocrlf).

> PipelinedMergeSortTaskTest is failing on Windows due to line end issues
> -----------------------------------------------------------------------
>
>                 Key: OAK-10338
>                 URL: https://issues.apache.org/jira/browse/OAK-10338
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: oak-run
>            Reporter: Manfred Baedke
>            Assignee: Manfred Baedke
>            Priority: Minor
>
> I think that this might actually be a bug and not a broken test. The problem 
> is that the method java.io.BufferedWrite.newLine() acts platform dependendly. 
> It's used here:
> https://github.com/apache/jackrabbit-oak/blob/25c01b81768c77e558078a92a31309910902f3a0/oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java#L732C29-L732C29
> As a result, the sorted file will have platform dependend line endings, while 
> the original file might not. I have no idea if that's a problem.
> [~thomasm], [~chetanm], [~nsantos], wdyt?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to