[ 
https://issues.apache.org/jira/browse/OAK-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781413#comment-17781413
 ] 

Julian Reschke edited comment on OAK-10523 at 10/31/23 3:00 PM:
----------------------------------------------------------------

Well, Oak doesn't throw the exception on read.

jackrabbit-spi-commons' name parser does exactly what it's documented to do.

Maybe we need to understand first what the goal is. Unless I'm missing 
something, we aren't planning to support SNS properly in Oak. Thus, creating a 
node with a name (not JCR name) including square braces will always fail.

What we can do is improve the diagnostics in case these braces made it into an 
Oak repo (see JCRVLT-724 and JCR-4983). Fixing OAK-10523 would also help, but 
only a little: export using FV would work, but then you'd end up with a package 
that can not be imported. Unless we add support in FV to rename these nodes 
(similar to what - IMHO - oak-upgrade does).




was (Author: reschke):
Well, Oak doesn't throw the exception.

jackrabbit-spi-commons' name parser does exactly what it's documented to do.

Maybe we need to understand first what the goal is. Unless I'm missing 
something, we aren't planning to support SNS properly in Oak. Thus, creating a 
node with a name (not JCR name) including square braces will always fail.

What we can do is improve the diagnostics in case these braces made it into an 
Oak repo (see JCRVLT-724 and JCR-4983). Fixing OAK-10523 would also help, but 
only a little: export using FV would work, but then you'd end up with a package 
that can not be imported. Unless we add support in FV to rename these nodes 
(similar to what - IMHO - oak-upgrade does).



> Basic SNS support returns invalid node names
> --------------------------------------------
>
>                 Key: OAK-10523
>                 URL: https://issues.apache.org/jira/browse/OAK-10523
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: jcr
>            Reporter: Julian Reschke
>            Priority: Minor
>
> When encountering names using index notation in storage, oak-jcr treats the 
> index suffix as part of the name. This causes issues with other components 
> that assume that the result of {{Node.getName()}} is indeed a valid JCR name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to