[ https://issues.apache.org/jira/browse/OAK-10551 ]
Julian Reschke deleted comment on OAK-10551:
--------------------------------------
was (Author: reschke):
Did some more digging.
In Felix SCR, "label" has only an effect when component meta type generation is
enabled.
Trying....
{noformat}
---
a/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
+++
b/oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/osgi/RepositoryManager.java
@@ -58,7 +58,7 @@ import org.osgi.framework.ServiceRegistration;
* create repository. This is done to prevent repository creation in scenarios
where repository needs
* to be configured in a custom way
*/
-@Component(policy = ConfigurationPolicy.REQUIRE)
+@Component(metatype = true, policy = ConfigurationPolicy.REQUIRE)
@References({
@Reference(referenceInterface = StatisticsProvider.class,
strategy = ReferenceStrategy.LOOKUP
@@ -104,20 +104,20 @@ public class RepositoryManager {
@Property(
intValue = DEFAULT_OBSERVATION_QUEUE_LENGTH,
- name = "Observation queue length",
+ label = "Observation queue length",
description = "Maximum number of pending revisions in a observation
listener queue")
private static final String OBSERVATION_QUEUE_LENGTH =
"oak.observation.queue-length";
@Property(
boolValue = DEFAULT_COMMIT_RATE_LIMIT,
- name = "Commit rate limiter",
+ label = "Commit rate limiter",
description = "Limit the commit rate once the number of pending
revisions in the observation " +
"queue exceed 90% of its capacity.")
private static final String COMMIT_RATE_LIMIT =
"oak.observation.limit-commit-rate";
@Property(
boolValue = DEFAULT_FAST_QUERY_RESULT_SIZE,
- name = "Fast query result size",
+ label = "Fast query result size",
description = "Whether the query result size should return an
estimation (or -1 if disabled) for large queries")
private static final String FAST_QUERY_RESULT_SIZE =
"oak.query.fastResultSize";
{noformat}
I get the labels into
target/classes/OSGI-INF/metatype/org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager.properties
> o.a.j.o.jcr.osgi.RepositoryManager declares OSGi properties that are not used
> at all
> ------------------------------------------------------------------------------------
>
> Key: OAK-10551
> URL: https://issues.apache.org/jira/browse/OAK-10551
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Manfred Baedke
> Assignee: Manfred Baedke
> Priority: Minor
>
> The declared property names are "Observation queue length", "Commit rate
> limiter" and "Fast query result size". The names the code actually uses are
> "oak.observation.queue-length", "oak.observation.limit-commit-rate" and
> "oak.query.fastResultSize".
> The names show up in the component description at runtime, which is just
> confusing.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
