[ 
https://issues.apache.org/jira/browse/OAK-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17827564#comment-17827564
 ] 

Joerg Hoh commented on OAK-10639:
---------------------------------

This improvement just optimizes the case positive case, that the provided is of 
the given nodetype. If that check fails (because the node does not have that 
nodetype), the mixintypes are loaded and evaluated.

> NodeImpl: calculate mixinTypes lazy
> -----------------------------------
>
>                 Key: OAK-10639
>                 URL: https://issues.apache.org/jira/browse/OAK-10639
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: jcr
>            Reporter: Joerg Hoh
>            Assignee: Joerg Hoh
>            Priority: Major
>              Labels: candidate_oak_1_22
>             Fix For: 1.62.0
>
>
> NodeImpl.isNodeType() calls ReadOnlyTypeManager.isNodeType(), but calculates 
> all mixinTypes directly, even if the mixinTypes are not required in 
> ReadOnlyTypeManager.isNodeType().
> The calculation of the mixinTypes could be converted into a Supplier<> type; 
> and the resolution could be done only when the mixinTypes are actually 
> required. This would save a few CPU cycles for the common case, where the 
> mixinTypes are not required.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to