[ 
https://issues.apache.org/jira/browse/OAK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829205#comment-17829205
 ] 

Manfred Baedke commented on OAK-6756:
-------------------------------------

See [PR#1371|https://github.com/apache/jackrabbit-oak/pull/1371]

The config UI in AEM is identical for all the components.
osgi-ds-metatype-diff reports:
{code}
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.DefaultSyncHandler
    MetaType
        Attributes
            - namespace = http://www.osgi.org/xmlns/metatype/v1.0.0 (String)
            + namespace = http://www.osgi.org/xmlns/metatype/v1.2.0 (String)
        Designates
            
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.DefaultSyncHandler
                - pid = 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.DefaultSyncHandler
 (String)
        ObjectClassDefinitions
            
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.DefaultSyncHandler
                - description = Description for 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.DefaultSyncHandler
 (String)
                + description =  (String)

org.apache.jackrabbit.oak.spi.security.authentication.external.impl.ExternalLoginModuleFactory
    Declarative Services
        Properties
            - jaas.controlFlag = SUFFICIENT (String)
            - jaas.ranking = 150 (Integer)
            - sync.handlerName = default (String)
        References
            syncManager
                - bind = bindSyncManager (String)
                - unbind = unbindSyncManager (String)
                + field = syncManager (String)
                + field-option = replace (String)
            securityProvider
                - bind = bindSecurityProvider (String)
                - unbind = unbindSecurityProvider (String)
                + field = securityProvider (String)
                + field-option = replace (String)
            contentRepository
                - bind = bindContentRepository (String)
                - unbind = unbindContentRepository (String)
                + field = contentRepository (String)
                + field-option = replace (String)
            idpManager
                - bind = bindIdpManager (String)
                - unbind = unbindIdpManager (String)
                + field = idpManager (String)
                + field-option = replace (String)
    MetaType
        Attributes
            - namespace = http://www.osgi.org/xmlns/metatype/v1.0.0 (String)
            + namespace = http://www.osgi.org/xmlns/metatype/v1.2.0 (String)
        Designates
            
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.ExternalLoginModuleFactory
                - pid = 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.ExternalLoginModuleFactory
 (String)
        ObjectClassDefinitions
            
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.ExternalLoginModuleFactory
                - description = Description for 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.ExternalLoginModuleFactory
 (String)
                + description =  (String)

org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration
    Declarative Services
        Properties
            - oak.security.name = 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration
 (String)
            - protectExternalId = true (Boolean)
    MetaType
        Attributes
            - namespace = http://www.osgi.org/xmlns/metatype/v1.0.0 (String)
            + namespace = http://www.osgi.org/xmlns/metatype/v1.2.0 (String)
        ObjectClassDefinitions
            
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration
                - description = Description for 
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration
 (String)
                + description =  (String)
                Attribute Definitions
                    oak.security.name
                        + id = oak.security.name (String)
                        + name = Oak security name (String)
                        + type = 1 (Integer)
                        + cardinality = 0 (Integer)
                        + defaultValue = 
[org.apache.jackrabbit.oak.spi.security.authentication.external.impl.principal.ExternalPrincipalConfiguration]
 (String[])
                        + optionLabels = [] (String[])
                        + optionValues = [] (String[])
{code}
which is fine IMHO, though there are differences regarding the declared 
properties. Note that there are also differences regarding the properties 
reported at runtime at system/console/components and these differences are not 
the same. Apparently

> Convert oak-auth-external to OSGi R7 annotations
> ------------------------------------------------
>
>                 Key: OAK-6756
>                 URL: https://issues.apache.org/jira/browse/OAK-6756
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: auth-external
>            Reporter: Robert Munteanu
>            Assignee: Manfred Baedke
>            Priority: Major
>              Labels: technical_debt
>         Attachments: cschneider-OAK-6756.osgi-diff.txt
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to