[ 
https://issues.apache.org/jira/browse/OAK-11060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876266#comment-17876266
 ] 

Marcel Reutegger commented on OAK-11060:
----------------------------------------

Created PR https://github.com/apache/jackrabbit-oak/pull/1668

> Avoid String allocation in ListRecord constructor
> -------------------------------------------------
>
>                 Key: OAK-11060
>                 URL: https://issues.apache.org/jira/browse/OAK-11060
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Marcel Reutegger
>            Assignee: Marcel Reutegger
>            Priority: Minor
>
> There are two size argument checks in the ListRecord constructor. Both 
> allocate a String as a potential error message.
> These checks should use another checkArgument() method with an error message 
> template to avoid String allocation.
> A micro benchmark shows cost of SegmentNodeState.getProperties() reduced by 
> 30% when String allocation is avoided in the constructor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to