[
https://issues.apache.org/jira/browse/OAK-11023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17878502#comment-17878502
]
Julian Reschke edited comment on OAK-11023 at 9/2/24 8:00 AM:
--------------------------------------------------------------
Work in progress: https://github.com/apache/jackrabbit-oak/tree/OAK-11023
This turns out to be somewhat nuclear, so we may want to re-think how to do
this in smaller steps.
Summary:
- Usage of {{newArrayList}} without arguments can be trivially replaced.
- Usage with a small list of members can be replaced by {{List.of(...)}} or
{{new ArrayList(array)}}. For {{List.of()}}, we need to be aware that it
produces read-only lists and does not support {{null}}.
- Usage with {{Iterators}} and {{Iterables}} requires using JDK streams
({{StreamSupport.stream}} and {{spliterator()}}). This is kind of verbose, so
we may want to consider supporting this in a utility class.
Also: I included changes to test code, which roughly double the amout of
changes; so we may want to rethink this.
was (Author: reschke):
Work in progress: https://github.com/apache/jackrabbit-oak/tree/OAK-11023
This turns out to be somewhat nuclear, so we may want to re-think how to do
this in smaller steps.
Summary:
- Usage of newArrayList without arguments can be trivially replaced.
- Usage with a small list of members can be replaced by List.of(...) or new
ArrayList(array). For List.of(), we need to be aware that it produces read-only
lists and does not support null.
- Usage with Iterators and Iterables requires using JDK streams
(StreamSupport.stream and spliterator()). This is kind of verbose, so we may
want to consider supporting this in a utility class.
Also: I included changes to test code, which roughly double the amout of
changes; so we may want to rethink this.
> Remove usage of Guava newArrayList
> ----------------------------------
>
> Key: OAK-11023
> URL: https://issues.apache.org/jira/browse/OAK-11023
> Project: Jackrabbit Oak
> Issue Type: Technical task
> Reporter: Rishabh Daim
> Assignee: Julian Reschke
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
