[ 
https://issues.apache.org/jira/browse/OAK-11090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17880144#comment-17880144
 ] 

Nicolas Ettlin commented on OAK-11090:
--------------------------------------

PR created here: [https://github.com/apache/jackrabbit-oak/pull/1697]

> Move the code that creates instances of RecordNumbers/SegmentReferences from 
> SegmentData out of Segment
> -------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-11090
>                 URL: https://issues.apache.org/jira/browse/OAK-11090
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>            Reporter: Nicolas Ettlin
>            Priority: Minor
>
> When initializing a Segment instance, we create 
> RecordNumbers/SegmentReferences instances with the data contained in 
> SegmentData. This operation is currently done from two private methods, 
> Segment#readRecordNumberOffsets and Segment#readReferencedSegments.
> By moving this code somewhere else (e.g. in static methods of 
> RecordNumbers/SegmentReferences), it would make it easier to reuse it and add 
> unit tests for these methods.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to